Update login screen to latest design. #789
Conversation
ntoll
requested review from
sssoleileraaa,
kushaldas and
redshiftzero
as code owners
|
Hey Nicholas: Inkscape did tweek the SVG quite a lot; the bottom row of hexagons is supposed to be the darkest, and they're not all supposed to be the same colors, across. Hence, the legibility issues you're experiencing with the |
|
Regarding how to footnote the window, I'd like to suggest that we use "SecureDrop Client v[$version]" or just the version number for now. We've not agreed to a name change yet (the VM is named |
|
That makes sense to me. Can we not upper-case the word |
I'd prefer to keep any such change out of the scope of this PR. The client currently uses "SecureDrop Client" elsewhere (notably in the window title), and it is capitalized in the docs, so we should stay consistent with current usage for now. |
|
just a headsup that i took a look at freedomofpress/securedrop-ux#17 (comment) see what the problem might have been with importing the original image. it looks like the original expects a bg color, so if we want to use that we'll need that hex value, otherwise the svg will need to be updated to include it: |
|
OK... once I have:
I'll update and rebase. :-) Thanks for the feedback folks..! |
|
One more thing Nicholas... on hover, the @eloquence will advise on the way to show the version number, but with the updated SVG it shd still show as the hex spec'd in Zeplin. |
|
@ninavizz that's what happens... "SIGNING IN" only shown once button is clicked and in flight. 👍 |
|
Just talked about this with Jen as well. Let's go with "SecureDrop Client v[$version]" for now. @redshiftzero, @ninavizz and I all agree that we likely eventually want to change the term "Client", but since we're using it in several places right now, let's use it here as well. Just having a version number without an application name, or just "SecureDrop v$[version]", could cause confusion with the SecureDrop server release version. We'll revisit the branding for both the SecureDrop Workstation and the Client, but the pilot will give us important guidance in that respect - we'll learn more about user expectations and mental models, which should inform any final name. If/when we do rename it from SecureDrop Client to something else, we can do it across the board (packages, repos, code, etc.). |
|
this needs to use the latest artwork provided by nina: freedomofpress/securedrop-ux#17 (comment) |
|
this still needs to use nina's latest bg artwork and use |
|
@ninavizz ack on the link to the SVG. Out of interest, why didn't you just attach it to a comment in this issue (rather than cut and paste it as text elsewhere)..? Just flagging that you can attach files. 👍 😝 📁 📎 😱 💻 |
|
OK... I'm so sorry about this @ninavizz, I really want to get this fixed up for you, but the universe appears to be conspiring against us. The file whose textual content you pasted at the link above, doesn't actually work as a SVG file. :-( It appears to be missing a whole section of XML from the start of the file (notice how the version that's pasted starts with an opening However, I have bodged something together by inserting an opening
(Note the black bar... or is that a transparency..?) I really really really want to fix this for you, but I have the sneaking suspicion that I've an SVG file that's missing a bunch of content from the start. Can you perhaps upload / attach the file I need to a reply to this issue please..? Thank you..! 👍 🤗 |
|
|
@ntoll You were correct, my friend—that first line of code was missing, and, nope, that black bar is not supposed to be there. Since the veiwport particulars are included in that first line-o-code, I'm hoping that now being included in the file, properly, solves the problem. TY for the clear guidance on what was wrong with it! :) |
|
Big hugs to you @ninavizz...! It works. Hurrah. Rebased and ready to review. Screenie below:
|
Description
Fixes #710.
This branch introduces four changes to fix #710 and thus freedomofpress/securedrop-ux#86
Obligatory screenie of this all in action:
Further discussion:
The images in the original ticket (#710) used the colour
#9fddffwhich looked like this:To my eyes this didn't provide enough contrast, so I've used Grimace Blue instead:
Finally, the SVG referenced in the original ticket (freedomofpress/securedrop-ux#17 (comment)) didn't work with Qt and, after some head scratching, I eventually had to import it into Inkscape and then re-save it so it worked. I've not changed anything about the SVG, but please check Inkscape hasn't made changes.
Test Plan
Could @ninavizz and @eloquence please check it looks good with Eyeball MK.1 👀.
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: