Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates recommended hostnames for Qubes staging #150

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Updates recommended hostnames for Qubes staging #150

merged 1 commit into from
Feb 11, 2021

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Feb 9, 2021

Documenting changes presented in
freedomofpress/securedrop#5712

Status

Ready for review

Description of Changes

  • Description:

  • Fixes Issue#

Testing

Release

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

rmol
rmol approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Rebuilt my base VMs following these instructions, everything still worked.

@rmol rmol merged commit 19bb5f9 into main Feb 11, 2021
@rmol rmol deleted the qubes-hostname-tweaks branch February 11, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmol rmol rmol approved these changes

@zenmonkeykstop zenmonkeykstop Awaiting requested review from zenmonkeykstop

@rocodes rocodes Awaiting requested review from rocodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorsch @rmol