Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NRK and HuffPo to ruleset #53

Merged
merged 3 commits into from
May 17, 2021
Merged

Add NRK and HuffPo to ruleset #53

merged 3 commits into from
May 17, 2021

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented May 11, 2021 •
edited by emkll
Loading

Status

Ready for review

Review Checklist

  • Changes to onboarded.txt are accurate
  • The file default.rulesets.TIMESTAMP.gz has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules
  • The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
  • index.html has been updated using ./update_index.sh

Post-Deployment Checklist

  • Added/modified onion names have been updated in the SecureDrop Directory

@rocodes rocodes requested a review from conorsch May 11, 2021 19:25
@rocodes rocodes changed the title Add NRK to ruleset (WIP) Add NRK and HuffPo to ruleset (WIP) May 13, 2021
@emkll emkll self-assigned this May 14, 2021
@emkll emkll changed the title Add NRK and HuffPo to ruleset (WIP) Add NRK and HuffPo to ruleset May 14, 2021
@emkll emkll removed their assignment May 14, 2021
emkll
emkll approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rocodes for preparing. I've appended the signature and tested the ruleset locally. I'll let you do a final review/merge as you see fit.

@rocodes
Copy link
Contributor Author

rocodes commented May 17, 2021

Thanks @emkll, also reviewed locally, lgtm.

@rocodes rocodes merged commit 19938d8 into main May 17, 2021
@rocodes rocodes deleted the nrk branch May 17, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

@conorsch conorsch Awaiting requested review from conorsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocodes @emkll