This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Right now we have these status codes provided by the
securedrop-proxy
qrexec service: https://github.com/freedomofpress/securedrop-proxy/blob/21c2963ffb383092142bafdda6fd5886857b675d/securedrop_proxy/proxy.py#L263 and https://github.com/freedomofpress/securedrop-proxy/blob/21c2963ffb383092142bafdda6fd5886857b675d/securedrop_proxy/proxy.py#L270 which we should be passing through for clients to use.(btw, we will probably treat a
ServerConnectionError
the same as aRequestTimeoutError
fromsecuredrop-client
, but we shouldn't make them the same from the SDK since we might want to customize behavior later)To test:
Once this is merged we can make an sdk release