Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

fix 109, rework exception handling #110

Merged
merged 5 commits into from
Feb 11, 2020
Merged

fix 109, rework exception handling #110

merged 5 commits into from
Feb 11, 2020

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Feb 7, 2020

Fixes #109

Right now we have these status codes provided by the securedrop-proxy qrexec service: https://github.com/freedomofpress/securedrop-proxy/blob/21c2963ffb383092142bafdda6fd5886857b675d/securedrop_proxy/proxy.py#L263 and https://github.com/freedomofpress/securedrop-proxy/blob/21c2963ffb383092142bafdda6fd5886857b675d/securedrop_proxy/proxy.py#L270 which we should be passing through for clients to use.

(btw, we will probably treat a ServerConnectionError the same as a RequestTimeoutError from securedrop-client, but we shouldn't make them the same from the SDK since we might want to customize behavior later)

To test:

  1. Run client on branch use-sdk-serverconnectionerror
  2. Install this branch of securedrop-sdk instead of 0.0.12
  3. Open client, connect, wait for sync. It should succeed.
  4. Pause staging server.
  5. You should NOT see the logout window come up as described here.
  6. Send a reply.
  7. See "The SecureDrop server cannot be reached" with a retry button.

Once this is merged we can make an sdk release

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the test plan and it fixes the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout errors are treated as auth errors
2 participants