Reserve 5% progress for VM reboot sequence #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when the last VM was upgraded, the progressBar value was set to 100% due to the exiting progress calculation. By substracting 5, we ensure the progress bar is set to 95% when the time comes to reboot the AppVMs.
rmol
approved these changes
Jan 31, 2020
cfm
pushed a commit
that referenced
this pull request
Apr 1, 2024
…equence Reserve 5% progress for VM reboot sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #411
The progress bar will now reach 100% only when reboots are applied to AppVMs
Test plan
make clone,make prep-dom0