Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename desktop icon #420

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Rename desktop icon #420

merged 1 commit into from
Jan 23, 2020

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jan 22, 2020 •
edited
Loading

"Launcher" is unnecessarily verbose for an icon shortcut and does
not match the window title.

Towards #413

Testing

  • After reprovisioning, the icon should have the new label. I have in fact tested this, so given that it's a simple string change, I leave it up to the reviewer if another run-through is required.

@eloquence
Rename desktop icon
c044f71 
"Launcher" is unnecessarily verbose for an icon shortcut and does
not match the window title.
@eloquence eloquence marked this pull request as ready for review January 23, 2020 04:19
emkll
emkll approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

minimalism

@emkll emkll merged commit 7b6bd4b into master Jan 23, 2020
@emkll emkll deleted the just-add-securedrop branch January 23, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eloquence @emkll