Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide release candidate for 0.3.0 series #552

Closed
wants to merge 4 commits into from
Closed

Conversation

emkll
Copy link
Contributor

@emkll emkll commented May 14, 2020

Status

For discussion

Description of Changes

Reverts changes from #550
Fixes #540

Proposes a new naming scheme for release candidates, as we cannot use ~

Testing

  • versioning scheme makes sense
  • changes from SecureDrop Workstation 0.3.0~rc1 #550 reverted cleanly
  • changelog is accurate
  • changes to update_version.sh work as expected:
    • ./update_version.sh 0.2.4.next.rc2 increments and proper sdist naming for tarball and source location, and the package builds using make dom0-rpm
    • ./update_version.sh 0.3.0 increments the version correctly, and package builds using make dom0-rpm
  • (Optional, this was already tested) Ensure 0.2.4.next.rc1 > 0.2.4.: Create two rpms and observe the output of dnf install $RPM and observe the upgrade/downgrade message at the confirmation prompt.
  • (Optional, this was already tested) the resulting rpm on this branch works in dom0 (sudo dnf install and ./securedrop-admin --apply)

emkll added 4 commits May 14, 2020 11:49
Because we cannot use the `~` character for prereleases due to qubes-dom0-update tooling, and we cannot use the `-` delimeter, let's use the `.` to increment version from the previous release to signal a release candidate for the next release. In the current case, the latest release is 0.2.4, the next release is 0.3.0, let's use 0.2.4.next.rc1 to signal the first release candidate for 0.3.0.
First release canadidate for Securedrop Workstation 0.3.0
@conorsch
Copy link
Contributor

@emkll See discussion in 0d50498. If you agree with the discussion there, considering pulling in the additional commit onto this PR prior to final review. (cc @rmol, as relevant to today's discussion in standup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create staging release candidate
2 participants