Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes migration flag from postinst #667

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

conorsch
Copy link
Contributor

Status

Ready for review

Description of Changes

Partially reverts 6cf625c.
Disables the automatic creation of a migrate-everything ask of the GUI
updater. We only want that migration to run once, so let's remove the
postinst task prior to the next prod release.

Testing

How should the reviewer test this PR?
Write out any special testing steps here.

Checklist

If you have made code changes

  • Linter (make flake8) passes in the development environment (this box may
    be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0 of a Qubes install

  • This PR adds/removes files, and includes required updates to the packaging
    logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

@conorsch conorsch requested review from eloquence and emkll March 17, 2021 23:37
@conorsch
Copy link
Contributor Author

I say "partially reverts" because I left the diff here https://github.com/freedomofpress/securedrop-workstation/pull/661/files#diff-6aca08490233cea9eacc7a2099a4e4d8bb404d7018cd3efac3b42ef3ef99d30dL29-L31 Seemed like we're likely to want to do this again, via postinst, so let's not block ourselves unnecessarily.

Partially reverts 6cf625c.
Disables the automatic creation of a migrate-everything ask of the GUI
updater. We only want that migration to run once, so let's remove the
postinst task prior to the next prod release.
@conorsch conorsch force-pushed the remove-migration-flag-from-postinst branch from cfb8e2a to 9507beb Compare March 29, 2021 16:42
@conorsch
Copy link
Contributor Author

Rebased on top of latest main, to pull in changes from #666.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by building the RPM, reinstalling it in dom0 and saw that the migration flag and dir are no longer there

@sssoleileraaa sssoleileraaa merged commit 6807419 into main Apr 8, 2021
@sssoleileraaa sssoleileraaa deleted the remove-migration-flag-from-postinst branch April 8, 2021 01:27
cfm pushed a commit that referenced this pull request Apr 1, 2024
…m-postinst

Removes migration flag from postinst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants