Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

securedrop-workstation-dom0-config 0.2.1 #3

Merged
merged 2 commits into from
Feb 26, 2020
Merged

securedrop-workstation-dom0-config 0.2.1 #3

merged 2 commits into from
Feb 26, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 26, 2020

Adds provisioning fixes discovered during the first release: freedomofpress/securedrop-workstation#468
Build logs available here: freedomofpress/build-logs@f38a8b6

Test Plan

  • In securedrop-workstation repo:
    • git tag -v 0.2.1 the tag is properly signed
    • Build logs, including artifact integrity are verified
    • CI is passing - the RPM is properly signed
    • rpm --delsign returns to the original rpm version, with checksum in build logs

zenmonkeykstop
zenmonkeykstop approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • git tag -v 0.2.1 the tag is properly signed
  • Build logs, including artifact integrity are verified
  • CI is passing - the RPM is properly signed
  • rpm --delsign returns to the original rpm version, with checksum in build logs

LGTM

@zenmonkeykstop zenmonkeykstop merged commit 51961ea into master Feb 26, 2020
@emkll emkll deleted the workstation-config-021 branch July 22, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenmonkeykstop zenmonkeykstop zenmonkeykstop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emkll @zenmonkeykstop