Skip to content

Commit

Permalink
Adds 'reason' for xfail on PaX tests
Browse files Browse the repository at this point in the history
Rightfully pointed out by @heartsucker during review. Cross-linked to
relevant issue. As to why we're using xfail rather than skip, the
"strict" setting on xfail will alert us if the tests unexpectedly start
passing (ain't that the dream?).
  • Loading branch information
Conor Schaefer committed Nov 30, 2018
1 parent 374675f commit 0955f37
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion molecule/testinfra/staging/common/test_grsecurity.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ def test_apt_autoremove(Command):
assert "The following packages will be REMOVED" not in c.stdout


@pytest.mark.xfail(strict=True)

@pytest.mark.xfail(strict=True,
reason="PaX flags unset at install time, see issue #3916")
@pytest.mark.parametrize("binary", [
"/usr/sbin/grub-probe",
"/usr/sbin/grub-mkdevicemap",
Expand Down

0 comments on commit 0955f37

Please sign in to comment.