Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safety & bandit checks not running in CI #4033

Closed
conorsch opened this issue Jan 15, 2019 · 0 comments
Closed

Safety & bandit checks not running in CI #4033

conorsch opened this issue Jan 15, 2019 · 0 comments

Comments

@conorsch
Copy link
Contributor

Description

The make safety and make bandit checks (for Python security vulnerabilities and static analysis, respectively) are no longer running in CI.

Steps to Reproduce

Observe lack of bandit/safety output in recent CI runs.

Expected Behavior

Both safety & bandit checks run in CI on every PR.

Actual Behavior

Neither safety nor bandit is run in CI.

Comments

The regression came in via #3909, flagged by @redshiftzero here #3909 (comment) . We should re-add calls to both targets in CI for all PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@conorsch