CI: Add back static analysis and checking Python dependencies for CVEs #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed during: #3909
emkll
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Great catch, thanks for fixing @redshiftzero.
Since this regression occurred as part of a large change, I'm not sure if adding code ownership to the file would guard against similar regressions in the future. We thankfully had GitHub notifications, which alerted repo maintainers via email when a library was out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4033
Changes proposed in this pull request:
Testing
CI job
static-analysis-and-no-known-cvesshould run and be green 💚Deployment
CI only
Checklist
If you made non-trivial code changes: