Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup script does not include custom logo #5868

Closed
eloquence opened this issue Mar 13, 2021 · 1 comment · Fixed by #5880
Closed

Backup script does not include custom logo #5868

eloquence opened this issue Mar 13, 2021 · 1 comment · Fixed by #5880
Assignees
@eloquence
Labels
bug
Milestone
1.8.1

Comments

@eloquence
Copy link
Member

Description

The backup script at https://github.com/freedomofpress/securedrop/blob/develop/install_files/ansible-base/roles/backup/files/backup.py currently does not add the custom logo, because it was not updated after #3057 changed the behavior to stop overwriting logo.png with the custom logo.

Steps to Reproduce

(Requires prod or staging instance.)

  1. Customize your logo
  2. Run ./securedrop-admin backup
  3. Inspect backup contents

Expected Behavior

Backup contains custom logo image.

Actual Behavior

Backup only contains original default logo.
@eloquence eloquence added the bug label Mar 13, 2021
@eloquence eloquence added this to the 1.9.0 milestone Mar 15, 2021
eloquence added a commit to freedomofpress/securedrop-docs that referenced this issue Mar 16, 2021
@eloquence
Add instructions for backing up and restoring logos
d24f58c 
These docs can be removed once a fix for
freedomofpress/securedrop#5868
is included in a production release.
@eloquence eloquence mentioned this issue Mar 16, 2021
Merged
3 tasks
@eloquence
Copy link
Member Author

freedomofpress/securedrop-docs#181 adds backup/restore docs for now, but I would suggest that we fix this properly with the next regular release at the latest.

eloquence added a commit to freedomofpress/securedrop-docs that referenced this issue Mar 16, 2021
@eloquence
Add instructions for backing up and restoring logos
e081076 
These docs can be removed once a fix for
freedomofpress/securedrop#5868
is included in a production release.
eloquence added a commit to freedomofpress/securedrop-docs that referenced this issue Mar 16, 2021
@eloquence
Add instructions for backing up and restoring logos
beef2f0 
These docs can be removed once a fix for
freedomofpress/securedrop#5868
is included in a production release.
@eloquence eloquence modified the milestones: 1.9.0, 1.8.1 Mar 24, 2021
@eloquence eloquence self-assigned this Mar 24, 2021
@eloquence eloquence mentioned this issue Mar 25, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eloquence eloquence

Labels
bug
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Correct backup location of custom logo freedomofpress/securedrop
1 participant
@eloquence