Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: add missing journalist templates in apparmor #3062

Merged
merged 2 commits into from
Feb 23, 2018
Merged

app: add missing journalist templates in apparmor #3062

merged 2 commits into from
Feb 23, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2018

Status

Ready for review

Description of Changes

add missing journalist templates in usr.sbin.apache apparmor

Testing

  • make build-debs
  • vagrant up /staging/
  • register an admin user
  • submit documents
  • navigate the journalist interface to see all templates that were added and verify they can be accessed

Deployment

The updated apparmor file will overwrite the current one.

@ghost ghost requested review from conorsch and msheiny as code owners February 22, 2018 23:09
@ghost
Copy link
Author

ghost commented Feb 22, 2018

FYI I manually verified all templates in the source interface are accounted for.

@ghost ghost mentioned this pull request Feb 22, 2018
Merged
1 task
@redshiftzero redshiftzero self-requested a review February 23, 2018 01:05
redshiftzero
redshiftzero approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch. To test I've:

✅ verified in via interactive testing on the journalist interface that these templates now work
✅ verified each journalist and source template indeed has a corresponding AppArmor rule

@redshiftzero redshiftzero merged commit 0e2ceb9 into develop Feb 23, 2018
@redshiftzero redshiftzero deleted the wip-dachary-apparmor-templates branch February 23, 2018 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch Awaiting requested review from conorsch

@msheiny msheiny Awaiting requested review from msheiny

Assignees
No one assigned
Labels
app bug journalist interface (JI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@redshiftzero