Develop fix documentation broken reference #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a fix to a broken reference of authenticated Tor hidden service at documentation.
.gitignore
Outdated
| @@ -104,6 +104,7 @@ ENV/ | |||
| *~ | |||
| *.swp | |||
| *.swo | |||
| tags | |||
There was a problem hiding this comment.
This IMO should go into global gitignore, the reason being the file name is customizable. The default filename for ctags is 'tags'.
There was a problem hiding this comment.
I concur on that. That's something for your global gitignore, rather than something in this git repo.
There was a problem hiding this comment.
I agree. I have removed that. Thanks @sayanchowdhury and @edenemmanuel for your review :)
anxiousnix
reviewed
Oct 25, 2018
|
@edenemmanuel I have updated the code according to your comments. Thanks! |
|
That last commit looks weird, Squash into one. |
|
@sayanchowdhury OOops, I forgot to push after squashing. Thanks for notifying though! |
ultimatecoder
force-pushed
the
develop-fix-documentation-broken-reference
branch
from
cc0b644 to
f1add93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
2. Edit vim generates tags files using ctags. This functionality helps to traverse to the definition of method, function or class. It is a meta file. Ignoring this file will solve the problem of mistakenly committing this file to the source.Steps to find broken reference at the documentation
Checklist
If you made changes to documentation:
make docs-lint) passed locally