added "filename" to reply creation api response #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
suggested changes
Jan 21, 2019
heartsucker
force-pushed
the
api-add-filename
branch
from
08e655e to
088db23
Compare
|
@kushaldas I accidentally committed a hack I use during development so I don't have to use TOTP when working on the client. That was resolved by a force push. |
kushaldas
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4047
Adds the
filenameto the API response when creating a reply.Testing
make test TESTFILES=tests/test_journalist_api.py::test_authorized_user_can_add_replyChecklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development container