Backport changelog #4210
Merged
Backport changelog #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
requested review from
conorsch,
emkll,
kushaldas,
msheiny and
redshiftzero
as code owners
emkll
reviewed
Feb 27, 2019
| @@ -1,6 +1,74 @@ | |||
| # Changelog | |||
|
|
|||
There was a problem hiding this comment.
nit: there's missing 0.13.0~rc1 at the top of the changelog
17 tasks
emkll
suggested changes
Feb 27, 2019
There was a problem hiding this comment.
it seems like not all changes from 9120b37 have been backported:
The following line was removed from the changelog in the commit above because it was introduced in 0.11.0:
* Prevent apt from following redirects on first install (#4058) on L35 of the changelog
heartsucker
force-pushed
the
backport-changelog
branch
from
1bec625 to
7257f92
Compare
|
@emkll I squashed that, so we should be good to go now. |
heartsucker
force-pushed
the
backport-changelog
branch
from
7257f92 to
cdac7fd
Compare
emkll
previously approved these changes
Feb 27, 2019
|
LGTM, thanks @heartsucker |
|
I'm consistently getting this failure. Any idea what the root cause is? I don't have access to those machines. |
heartsucker
force-pushed
the
backport-changelog
branch
from
cdac7fd to
fa24797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Toward #4124
Backport the changelog, bump the version number.