On NoScript XSS info page, add link back to submission page #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmol
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
eloquence
reviewed
Feb 28, 2019
redshiftzero
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Adds a link back to the submission page at the bottom of the page explaining how to work around the NoScript cross-site sanitization upload problem.
Fixes #4208
Testing
On the submission page, click the "Show me how" link to get to the instructions for working around the NoScript XSS upload problem. At the bottom of the page should be a "Back to submission page" link. Click it to verify that it takes you back to the source submission page.
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development container