extend staging timeout for long ansible tasks

[heartsucker]

Status

Ready for review

Description of Changes

Fixes timeout errors in CI, closes #4220

Testing

Does CI pass? In particular this Ansible step:

Perform safe upgrade to ensure all the packages are updated

Deployment

CI only.

[heartsucker]

Even with extending this to 20 minutes, we're timing out. I think we might be hitting some kind of interactive prompt, or we may need to update the base box to the latest version to minimize the number of packages that are being updated during the step that fails.

[heartsucker]

Hmm actually this build (different branch) passed that step, but without the extended timeout. So really I have no idea what's going on here. https://circleci.com/gh/freedomofpress/securedrop/23880?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

[emkll]

Thanks @heartsucker for the fix. The problem indeed appears to be intermittent and might be dependent on network conditions. I've appended a commit 8243d9b to your branch, which should also cover the per-PR step, based on your changes:

The timeout was added to staging-test-with-rebase, whereas staging-test-with-rebase-xenial is step that is being run per-PR (this was introduced very recently, see #4158). The naming is somewhat counter-intuitive, though Makefiles are to be renamed as part of #4155.

EDIT: That seems to resolve: https://circleci.com/gh/freedomofpress/securedrop/23907

[codecov-io]

Codecov Report

Merging #4218 into develop will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4218      +/-   ##
===========================================
- Coverage    84.79%   84.72%   -0.08%     
===========================================
  Files           43       43              
  Lines         2782     2782              
  Branches       303      303              
===========================================
- Hits          2359     2357       -2     
- Misses         355      356       +1     
- Partials        68       69       +1

Impacted Files	Coverage Δ
securedrop/securedrop/crypto_util.py	94.73% <0%> (-1.76%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d012f14...8243d9b. Read the comment docs.

[redshiftzero]

👍