Add staging-specific creation of test data #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have --staging flag to the create-dev-data.py script so that we can easily create an user in the staging or prodcution test and then use the functional tests to test the instance. (cherry picked from commit b08a0d7)
Typically these actions were done manually but lets get our good old friend ansible to run them for us (at least under the upgrade env).
rmol
requested review from
conorsch,
emkll,
heartsucker,
kushaldas,
msheiny and
redshiftzero
as code owners
heartsucker
approved these changes
Mar 25, 2019
kushaldas
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This PR cherry-picks a few commits from tbb-0.12.0 to add a
--stagingargument to thecreate-dev-data.pyscript, which skips creation of the second journalist and all source accounts.Fixes #4286.
Testing
As in
securedrop/tests/functional/README.md:sudo -u www-data bashcd /var/www/securedrop/./manage.py reset# This will clean the DB for testing./create-dev-data.py --stagingVerify that only the first journalist account was added to the database:
cd /var/lib/securedropsqlite3 db.sqliteselect * from journalists;Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development containerIf you made non-trivial code changes: