Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Trusty-specific logic in Ansible scripts #4422

Merged
merged 4 commits into from
May 13, 2019
Merged

Remove Trusty-specific logic in Ansible scripts #4422

merged 4 commits into from
May 13, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented May 9, 2019

Status

Ready for review

Description of Changes

Fixes #4341 : Some Trusty-specific logic was not completely removed in #4416

Testing

  • CI passes
  • There are no further references to trusty

Deployment

These changes are limited to the Ansible scripts and development environment. The install process will no longer work under Trusty

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@eloquence eloquence mentioned this pull request May 10, 2019
Closed
@redshiftzero
Copy link
Contributor

some other places we should update as part of this change:

  1. we have some xenial/trusty branching in securedrop-config's postinst for issue [xenial] Reinstate LTS upgrade notification #4104, we could remove that now

  2. test_platform in molecule/testinfra/staging/common needs update

  3. molecule/vagrant-packager/package.py has trusty references (will be confusing if we don't at least update the comments to indicate we removed trusty logic)

emkll added 4 commits May 13, 2019 10:25
@emkll
Remove molecule Trusty upgrade boxes metadata
ffe8a57
@emkll
Remove Trusty-specific Ansible logic
58734c4 
- Apache2 dependency management
- Apt version checks
- AppArmor tests
@emkll
Remove Trusty-specific logic in builder and update scripts
5494b56
@emkll
Further removal of Trusty-specifc logic:
29e0091 
* Remove update_release_available_script
* Updated platform tests
* Updated vagrant-packager comments
@emkll emkll force-pushed the 4341-more-trusty-logic-removal branch from aaf4140 to 29e0091 Compare May 13, 2019 14:39
redshiftzero
redshiftzero approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @emkll, my comments were addressed

@redshiftzero redshiftzero merged commit ff00f4c into develop May 13, 2019
@redshiftzero redshiftzero deleted the 4341-more-trusty-logic-removal branch May 13, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redshiftzero redshiftzero redshiftzero approved these changes

@conorsch conorsch Awaiting requested review from conorsch

@kushaldas kushaldas Awaiting requested review from kushaldas

@msheiny msheiny Awaiting requested review from msheiny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Trusty-specific logic from application code and dev env
2 participants
@emkll @redshiftzero