Update messages for manually flagged sources for accuracy #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
requested review from
conorsch,
emkll,
heartsucker,
kushaldas,
msheiny and
redshiftzero
as code owners
The key issue here is that the previous message told sources that their submission had only just been passed through, which is not true. This message is also significantly shorter. Removed the icon, as the "relieved face" emoji, which is only used for this message, is no longer a good fit with the revised text. Resolves #4420
eloquence
force-pushed
the
flag-for-reply-accuracy
branch
from
edd63db to
9caf9d4
Compare
heartsucker
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key issue here is that the previous message told sources that their submission had only just been passed through, which is not true. This message is also significantly shorter. Removed the icon, as the "relieved face" emoji, which is only used for this message, is no longer a good fit with the revised text.
Resolves #4420
Status
Ready for review
Screenshot for UX review
Deployment
No special considerations
Checklist
make -C securedrop testpasses locally