[0.13.0] Backport 4435 to 0.13.0 #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkll
requested review from
conorsch,
heartsucker,
kushaldas,
msheiny and
redshiftzero
as code owners
(cherry picked from commit 78cfd00)
Use no-binary and require hashes option at wheel build time, and generate new requirements file (without hashes) for securedrop-app-code deb package. This is because dpkg-buildpackage modifies the zip data of the built wheel files, making it difficult to require hashes at install-time server-side. The deb package is signed and as such would be difficult to tamper with wheel contents in transit (cherry picked from commit 4418f4c)
This will make the build process marginally faster and provide better integrity (cherry picked from commit 3936aec)
Adds python-wheel and latest security patches (cherry picked from commit 6cf4392)
Before, build would fail due to absence of wheels in the /var/securedrop/wheelhouse, at a later step. (cherry picked from commit bd2f1cb)
emkll
force-pushed
the
backport-4435-to-0.13.0
branch
from
acf4b57 to
2b645bc
Compare
Codecov Report
@@ Coverage Diff @@
## release/0.13.0 #4443 +/- ##
===============================================
Coverage 83.72% 83.72%
===============================================
Files 44 44
Lines 2956 2956
Branches 321 321
===============================================
Hits 2475 2475
Misses 404 404
Partials 77 77Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Backports #4435 to the 0.13.0 release branch
Testing