api: expose journalist first and last name if set

[redshiftzero]

Status

Ready for review

Description of Changes

This is a followup from #4425. In this PR we expose the journalist first name and last name added in #4425 on:

• the user endpoint
• the reply endpoints (since this is the place where we want to use them in the client, for each conversation)

Testing

Reading the diff and tests should be sufficient, but here are steps to test an endpoint that has the first name / last name added with curl for convenience:

0. Get a token curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"ADDYOURSHERE"}' 127.0.0.1:8081/api/v1/token

1. Get curl -X GET -H "Content-Type: application/json" -H "Authorization: Token ADDYOURSHERE" 127.0.0.1:8081/api/v1/user

{
  "first_name": "",
  "is_admin": true,
  "last_login": "2019-05-23T19:07:13.967833Z",
  "last_name": "",
  "username": "journalist",
  "uuid": "e1f5636c-d141-4cac-bc6d-7ed1e6d06dae"
}

Deployment

No special considerations

Checklist

If you made changes to the server application code:

• Linting (make lint) and tests (make -C securedrop test) pass in the development container (I'm relying on CI, only ran the API tests)

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

If you made changes to documentation:

• Doc linting (make docs-lint) passed locally

[codecov-io]

Codecov Report

Merging #4459 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4459   +/-   ##
========================================
  Coverage    83.21%   83.21%           
========================================
  Files           45       45           
  Lines         3069     3069           
  Branches       332      332           
========================================
  Hits          2554     2554           
  Misses         430      430           
  Partials        85       85

Impacted Files	Coverage Δ
securedrop/securedrop/models.py	89.22% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537dd23...cb8b644. Read the comment docs.

[rmol]

👍 Tested these endpoints as well as the reply endpoints, to check the doc changes. All looks good.

[kushaldas]

This is good, thank you 🌈 🌈 🌈

[redshiftzero]

hey @kushaldas this needs a restamp (I did make a change above so your review was dismissed)

[kushaldas]

Approved.