Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old kernels as part of common role and not via grsecurity role #4641

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jul 24, 2019

Status

Ready for review

Description of Changes

Fixes #4637

Changes proposed in this pull request:

Testing

  • CI passes
  • Clean install on this branch in prod vms is successful
  • Subsequent install is also successful

Deployment

This change only affects the Ansible logic on initial or subsequent installs

Checklist

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

This was initially done as part of the  grsecurity role

The removal must be done before installing holding tor, as if there are packages to be autoremoved, the tor hold talk will fail.
@kushaldas
Copy link
Contributor

This PR works locally on my system using the latest 201906.18.0 vagrant boxes.

@msheiny
Copy link
Contributor

msheiny commented Jul 25, 2019

Retriggering tests here - to test intake of newer GCP image

@emkll
Copy link
Contributor Author

emkll commented Jul 25, 2019

fetch-tor-debs will fail due to #4626, but should be OK to merge once staging-test-with-rebase passes.

@emkll emkll marked this pull request as ready for review July 25, 2019 17:23
- apt

- name: Validate that all installed kernels are grsecurity-hardened.
assert:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emkll i think this is fine for now but in the future this might have been easier/cleaner to just slap into a single grep command that exits 1 or 0

Copy link
Contributor

@msheiny msheiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zenmonkeykstop zenmonkeykstop merged commit 62e96ff into develop Jul 25, 2019
@emkll emkll mentioned this pull request Sep 6, 2019
23 tasks
@emkll emkll deleted the xenial-vagrant-20190618-support branch October 8, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest Xenial vagrant boxes fail on staging
4 participants