Update translations for 1.0.0 #4806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most recent build shows CI failure as described in #4818. Since #4819 landed on develop, a rebase on this branch should resolve, getting the translation tests passing reliably again. |
2 tasks
contributors: Thalia Rahme updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Benet (BennyBeat) R. i Camps John Smith updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Ettore Atalan John Hensley Robin Schubert updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Dimitris Maroulidis updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Adolfo Jayme-Barrientos carlos erinm updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: AO updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: AbhayKaushik Chandan Kumar (raukadah) Drashti updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Oktavia Sveinn í Felli updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Beatrice Martini Claudio Arseni Giandomenico Lombardi updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: John Hensley Øyvind Bye Skille updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Pander Thom kwadronaut updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: communiaa updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: mickael e updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Adham Kurbanov erinm updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Jonas Franzén updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Kaya Zeren tekrei updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
contributors: Chi-Hsun Tsai updated from: repo: https://github.com/freedomofpress/securedrop-i18n revision: 75d090c
rmol
force-pushed
the
i18n-merge-1.0.0
branch
from
fb5dded to
0d0c552
Compare
rmol
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
emkll
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Thanks @rmol ! Reviewed the diff for all language and ensured no tags/scripts were introduced in the translations, LGTM. Small note re: incompletely translated language, let's observe the behavior in RC4.
Good to merge once the translation tests pass
| @@ -983,6 +983,16 @@ msgstr "" | |||
| msgid "Forgot your codename?" | |||
| msgstr "Ți-ai uitat numele de cod?" | |||
|
|
|||
| #: source_templates/footer.html:7 | |||
There was a problem hiding this comment.
Let's make sure we test the footer behavior with ro and ensure the english-language messages are properly displayed for these strings.
|
All translation tests passed in https://circleci.com/gh/freedomofpress/securedrop/34351 , merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Updated translations for 1.0.0.
Testing
make test TESTFILES=tests/pageslayoutsecuredrop/tests/pageslayout/screenshots/Deployment
No deployment concerns.
Checklist
If you made non-trivial code changes: