Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qa_loader.py nicer for load and workstation testing #5174

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 26, 2020

Status

Ready for review

Description of Changes

This version:

  • generates legible names, messages, and replies
  • generates recent dates
  • generates source keys
  • permits specification of exact numbers:
    • of journalists and sources
    • number of submissions and replies per source
    • fraction of sources starred
    • fraction of sources replied to

The resulting database produces sensible API results, so functions better for testing the SecureDrop Workstation.

Testing

Create a staging environment from this branch. Populate it with the new qa_loader.py and confirm that the resulting data counts match your specifications.

Deployment

Dev only.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

rmol and others added 3 commits April 9, 2020 16:12
This version:
- generates legible names, messages, and replies
- generates recent dates
- generates source keys
- permits specification of exact numbers:
  - of journalists and sources
  - number of submissions and replies per source
  - fraction of sources starred
  - fraction of sources replied to

The resulting database produces sensible API results, so functions
better for testing the SecureDrop Workstation.
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from my side, I will wait for someone else to have a second look, and then merge.

@zenmonkeykstop
Copy link
Contributor

Also LGTM, merging.

@zenmonkeykstop zenmonkeykstop merged commit 174b29d into develop Apr 17, 2020
@zenmonkeykstop zenmonkeykstop deleted the qa-loader-overhaul branch April 17, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants