Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates tor to 0.4.2.7 #5192

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Updates tor to 0.4.2.7 #5192

merged 1 commit into from
Apr 14, 2020

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Apr 13, 2020

Status

Ready for review.

Description of Changes

Changes proposed in this pull request:

Includes package version bumps in the fetch logic, which unbreaks the
associated nightly CI job. Test vars have been updated to expect the new
version info.

Fixes #5070

Testing

So far, I've performed simple spot testing of the Source Interface, v2 & v3, and observed no problems. More vigorous testing is required to confirm no problems with these new packages.

  1. Fetch the new proposed packages from tor: bumps packages to 0.4.2.7-1 securedrop-apt-test#38
  2. Run the staging environment locally
  3. Copy in the new deb packages and install them with sudo dpkg -i *.deb
  4. Perform manual interactive testing of the source & journalist interfaces, both v2 & v3. Confirm you can submit, download & decrypt, reply, and read the reply as the source.

If no problems are found, then we can proceed with publishing the packages to apt-test, and using them in staging environments going forward. Next steps:

  1. Review and merge tor: bumps packages to 0.4.2.7-1 securedrop-apt-test#38
  2. Rerun CI on this PR, confirm passing

Deployment

Significant implications. All prod instances will be updated to this new version of tor, when released as part of SecureDrop 1.3.0.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

Includes package version bumps in the fetch logic, which unbreaks the
associated nightly CI job. Test vars have been updated to expect the new
version info.
@conorsch conorsch marked this pull request as ready for review April 13, 2020 19:22
@emkll
Copy link
Contributor

emkll commented Apr 14, 2020

Testing has been done as follows prior to merging the debs PR:

  • tor packages install successfully
  • tor v2/v3 onion services work as expected
  • verified package checksums prior to merge

Debs have been merged, restarted CI in https://circleci.com/workflow-run/3eb8afcc-d9f5-4411-8d3e-207537139493

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've observed some local issues when provisioning the staging environment (described here: #5193)

It is definitely unrelated to changes introduced here (and this PR doesn't affect any install/tor logic, only helper command to download tor debs). CI is passing, this PR is good to merge, and tor 0.4.2.7 is on the test apt server.

@emkll emkll merged commit 6ad1662 into develop Apr 14, 2020
@zenmonkeykstop zenmonkeykstop mentioned this pull request Apr 29, 2020
22 tasks
@zenmonkeykstop zenmonkeykstop deleted the 5070-update-tor branch May 7, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tor to 0.4.2.x series
2 participants