Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description of Changes
Changes proposed in this pull request:
Includes package version bumps in the fetch logic, which unbreaks the
associated nightly CI job. Test vars have been updated to expect the new
version info.
Fixes #5070
Testing
So far, I've performed simple spot testing of the Source Interface, v2 & v3, and observed no problems. More vigorous testing is required to confirm no problems with these new packages.
sudo dpkg -i *.deb
If no problems are found, then we can proceed with publishing the packages to apt-test, and using them in staging environments going forward. Next steps:
Deployment
Significant implications. All prod instances will be updated to this new version of tor, when released as part of SecureDrop 1.3.0.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made changes to
securedrop-admin
:make -C admin test
) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint
) passed locallyIf you added or updated a code dependency:
Choose one of the following: