Fix sentence about onion services v2

[comradekingu]

Status

Ready for review

Description of Changes

Fixes #.

https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=8bf29e52aaf6db39#comments

Changes proposed in this pull request:

Testing

How should the reviewer test this PR?

See https://blog.torproject.org/v2-deprecation-timeline check whether SecureDrop deprecation differs from Tor plan.

Deployment

Any special considerations for deployment? Consider both:

1. Upgrading existing production instances.
2. New installs.

Checklist

If you made changes to the server application code:

• Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

• Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

• Configuration tests pass

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

If you made changes to documentation:

• Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

• I have performed a diff review and pasted the contents to the packaging wiki
• I would like someone else to do the diff review

[zenmonkeykstop]

Hi @comradekingu ! The February 2021 date refers to the plan for retirement of v2 onion service support from SecureDrop rather than from Tor in general. The point about capitalization is well-taken though. (SD documentation is very inconsistent in this regard so a larger fix is probably called for.)

[eloquence]

Hi @comradekingu, thanks for this PR. As Kev notes, we're happy to standardize on the lower case "onion services", but would prefer to keep the wording otherwise as it is.

As Kev noted above, SecureDrop's deprecation period of v2 onion services begins with the SecureDrop 1.5.0 release (July 28, 2020) and ends with the SecureDrop 2.0.0 release (February 2021), when support for v2 will be removed entirely. Tor's deprecation timeline begins in September 2020, with support for v2 scheduled for removal in July 2021. While the term is often used imprecisely, deprecation means that the use of a feature is discouraged, typically followed by the complete removal of said feature.

[comradekingu]

From my understanding the v2 comes after the "onion service". Is "for security reasons" important?
Feel free to change things around.

[eloquence]

From my understanding the v2 comes after the "onion service".

Both are valid in English, Tor (and the Internet at large) has generally preferred "v[2-3] onion services" except for the most recent blog post, see e.g.:
https://twitter.com/search?q=from%3Atorproject%20v3&src=typed_query&f=live

Is "for security reasons" important?

Yes, during development we iterated on this language a couple of times, and agreed we wanted to bring attention to this aspect -- this is just not something that's "nice to have", but important for source/journalist security.

[eloquence]

We discussed this today at SecureDrop standup and decided to go with the slightly more verbose variant that's currently in develop. This string will only be seen by journalists, not sources, and we want to err on the side of being explicit about the impact. However, we're on board with standardizing to the lower case onion services variant as you suggest, and will do so separately.

Thanks for your input here @comradekingu, and for advocating for brevity in UI messaging - a concern I generally share.