Remove unused/disabled source onion service info files #5404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5400.
If a site disables v2 onion services, remove the file used to decide to show the deprecation warning.
The v3 equivalent is also removed if v3 services are disabled, though downgrading to v2-only is not really possible -- more work would be needed in the playbooks, and that's probably not something we should support at this point.
Testing
securedrop-admin sdconfig
to enable v3 and disable v2 onion services.securedrop-admin install
. This should complete successfully, and in the Ansible output you should seeRemove source v2 onion service info if not enabled
followed byExpose source v3 onion service info to app
./var/lib/securedrop
. There should be nosource_v2_url
, justsource_v3_url
.securedrop-admin tailsconfig
.Deployment
This enables admins to disable v2 onion services and remove the deprecation warning from the journalist interface.
Checklist
If you made changes to
securedrop-admin
:make -C admin test
) pass in the admin development containerIf you made non-trivial code changes: