Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/disabled source onion service info files #5404

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jul 23, 2020

Status

Ready for review

Description of Changes

Fixes #5400.

If a site disables v2 onion services, remove the file used to decide to show the deprecation warning.

The v3 equivalent is also removed if v3 services are disabled, though downgrading to v2-only is not really possible -- more work would be needed in the playbooks, and that's probably not something we should support at this point.

Testing

  • Start with a deployment that has v2 onion services enabled. VM or hardware is most straightforward at this point, but I'll see if it can be tested in a staging environment.
  • Run securedrop-admin sdconfig to enable v3 and disable v2 onion services.
  • Run securedrop-admin install. This should complete successfully, and in the Ansible output you should see Remove source v2 onion service info if not enabled followed by Expose source v3 onion service info to app.
  • Log in to the app server and list the contents of /var/lib/securedrop. There should be no source_v2_url, just source_v3_url.
  • Run securedrop-admin tailsconfig.
  • Log in to the journalist interface. There should be no v2 deprecation warning.

Deployment

This enables admins to disable v2 onion services and remove the deprecation warning from the journalist interface.

Checklist

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If a site disables v2 onion services, remove the file used to decide
to show the deprecation warning.

The v3 equivalent is also removed if v3 services are disabled, though
downgrading to v2-only is not really possible -- more work would be
needed in the playbooks, and that's probably not something we should
support at this point.
@zenmonkeykstop zenmonkeykstop self-assigned this Jul 23, 2020
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan passes, LGTM!

@zenmonkeykstop zenmonkeykstop merged commit 29efec0 into develop Jul 23, 2020
@zenmonkeykstop zenmonkeykstop mentioned this pull request Jul 23, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.5.0] [QA] v2 onion services files are not removed during v3 migration, so deprecation warning still shows
2 participants