Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to journalist_app.account #5460

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Add type annotations to journalist_app.account #5460

merged 2 commits into from
Sep 2, 2020

Conversation

nabla-c0d3
Copy link
Contributor

@nabla-c0d3 nabla-c0d3 commented Aug 19, 2020 •
edited
Loading

Status

Ready for review.

Description of Changes

To help with #4399 , this PR adds type annotations to:

  • journalist_app/utils.py
  • journalist_app/account.py

It also updates a few other annotations, needed for mypy to pass.

@nabla-c0d3 nabla-c0d3 marked this pull request as ready for review August 19, 2020 15:20
@zenmonkeykstop zenmonkeykstop self-assigned this Aug 19, 2020
@zenmonkeykstop zenmonkeykstop removed their assignment Aug 20, 2020
@kushaldas kushaldas self-assigned this Aug 20, 2020
@nabla-c0d3 nabla-c0d3 changed the title Add type annotations to journalist_app Add type annotations to journalist_app.account Aug 22, 2020
@nabla-c0d3 nabla-c0d3 mentioned this pull request Aug 22, 2020
Merged
rmol
rmol reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it's going to need a rebase.

kushaldas
kushaldas approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look okay, approved. Thank you.

@kushaldas kushaldas merged commit 334864a into freedomofpress:develop Sep 2, 2020
@nabla-c0d3 nabla-c0d3 deleted the add-types-to-journalist-utils branch October 24, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmol rmol rmol left review comments

@kushaldas kushaldas kushaldas approved these changes

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees

@kushaldas kushaldas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabla-c0d3 @kushaldas @rmol @zenmonkeykstop