Fetches tor packages for Focal #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `fetch-tor-packages` to pull tor packages for both Xenial & Focal, so we can begin hosting the latter, possible since freedomofpress/securedrop-apt-test#57 Closes #5481.
conorsch
pushed a commit
to freedomofpress/securedrop-apt-test
that referenced
this pull request
Sep 4, 2020
Fetched via the new logic in freedomofpress/securedrop#5482
2 tasks
kushaldas
approved these changes
Sep 4, 2020
| # Use same container image as the Xenial build scenario | ||
| image: "quay.io/freedomofpress/sd-docker-builder-xenial@sha256:{{ image_hash }}" | ||
| # Use same container image as the build scenario | ||
| image: "{{ item.image }}@sha256:{{ lookup('pipe', 'egrep -v ^# ../builder-'+item.distro+'/image_hash') }}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Updates the
fetch-tor-packagesto pull tor packages for both Xenial &Focal, so we can begin hosting the latter, possible since
freedomofpress/securedrop-apt-test#57
Closes #5428
Testing
make fetch-tor-packagesand note the checksums forbuild/xenial/tor*.2.. On this branch, run
make fetch-tor-packagesand confirm no errors.build/xenial/. Confirm their checksums match those from step 1.build/focal/. Confirm they match byte-for-byte what's found in https://deb.torproject.org/torproject.org/pool/main/t/tor/Once you've approved these changes, please take a gander at freedomofpress/securedrop-apt-test#60, which includes the focal packages fetched via this logic.
Deployment
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: