Finish adding type annotations to journalist_app #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nabla-c0d3, thanks again for your work on adding type annotations. Now that #5464 is merged, do you have time to finish up the follow-up PRs, or would you like our help with that? |
|
@eloquence No problem, I will take care of the follow up PRs |
nabla-c0d3
force-pushed
the
add-types-to-journalist-app
branch
3 times, most recently
from
2b94454 to
0a341f7
Compare
|
Ready for review. |
Fix types Return HTTP 405 for wrong method
nabla-c0d3
force-pushed
the
add-types-to-journalist-app
branch
from
0a341f7 to
fffd827
Compare
rmol
suggested changes
Oct 14, 2020
rmol
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready.
Description of Changes
To help with #4399 , this PR adds type annotations to remaining files in journalist_app and enforces typing in this app.