Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates CI boxes for staging tests #5658

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Updates CI boxes for staging tests #5658

merged 1 commit into from
Nov 30, 2020

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Nov 30, 2020 •
edited
Loading

Status

Ready for review

Description of Changes

Related to #5642

Pins the Vagrant box versions inside the Buster GCP box,
as described in [0]:

  • 16.04 - 202008.16.0
  • 20.04 - 202008.16.0

[0] #5642 (comment)

Testing

  1. Is CI passing? That's good enough
  2. Optionally we can rebase PR Add staging-with-rebase-focal to CI and fix testinfra tests #5638 to verify, but I'm fine merging now, rebasing 5638, and following up with more box changes if required.

Deployment

No, CI only.

Updates CI boxes for staging tests
8a4d446 
Pins the Vagrant box versions inside the Buster GCP box,
as described in [0]:

  * 16.04 - 202008.16.0
  * 20.04 - 202008.16.0

[0] #5642 (comment)
@conorsch conorsch requested review from emkll and kushaldas November 30, 2020 20:22
@conorsch conorsch marked this pull request as ready for review November 30, 2020 20:22
emkll
emkll approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing, LGTM

@emkll emkll merged commit 1d50b6e into develop Nov 30, 2020
@emkll emkll deleted the 5642-pin-ci-box-versions branch November 30, 2020 20:23
This was referenced Nov 30, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

@kushaldas kushaldas Awaiting requested review from kushaldas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorsch @emkll