Added Makefile and requirements changes to allow make safety to pass
#5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `--ignore 39252` flag for check related to unused functionality in cryptography 3.2.1 - Updated `py` dependency in develop and test requirements to 1.10.0
zenmonkeykstop
requested review from
kushaldas and
redshiftzero
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5686 +/- ##
========================================
Coverage 85.54% 85.54%
========================================
Files 52 52
Lines 3771 3771
Branches 474 474
========================================
Hits 3226 3226
Misses 440 440
Partials 105 105 Continue to review full report at Codecov.
|
emkll
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
thanks @zenmonkeykstop, LGTM, we can ignore 39252 for the time being and update cryptography once we've deprecated support for Xenial/Python3.5 as part of #4768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5685.
--ignore 39252flag for check related to unused functionality in cryptography 3.2.1pydependency in develop and test requirements to 1.10.0Testing
make safetypasses locallypyfrom 1.9.0 to 1.10.0 in develop and test requirements.Deployment
CI & development only
Checklist
If you made non-trivial code changes: