-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resolvconf dependency on Focal #5809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here look functionally good to me, as tested in Focal VMs. It looks like systemd-resolved is disabled by default on Focal install.
Its presence is not strictly necessary here: running a local resolver would only be helpful to cache DNS requests
Did you find |
It is enabled by default on a fresh focal install:
It is however disabled in Debian by default per the below and [1]
If we were to enable (or rather, preserve enabled) [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866624 |
Looks like systemd-resolved is enabled by default on a clean Focal install. To test, I ran
See context in #5638. At the very least, we should have a config test verifying that state, but that doesn't block here. @kushaldas please refer the relevant documentation for systemd-resolved and resolv.conf. If you agree with the behavior here, go ahead and merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DNS still working, no resolvconf
installed on the servers. Approved.
Status
Ready for review
Description of Changes
Stops installing
resolvconf
on Focal. Keepssystemd-resolved
disabled. Name resolution keeps working:man resolv.conf
.Testing
git checkout -b remove-resolvconf origin/remove-resolvconf
make build-debs-focal
make staging-focal
Servers should not have
resolvconf
installed, norsystemd-resolved
running. DNS lookups should still succeed.Deployment
Changes resolver configuration.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
Choose one of the following: