fix: Recreate store directory if not there for existing source #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekj117
force-pushed
the
recreate-store-directory
branch
from
bc5d4b1 to
1a096ce
Compare
prateekj117
changed the title
prateekj117
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #5944 +/- ##
===========================================
- Coverage 85.37% 85.30% -0.07%
===========================================
Files 53 53
Lines 3876 3879 +3
Branches 480 481 +1
===========================================
Hits 3309 3309
- Misses 455 457 +2
- Partials 112 113 +1
Continue to review full report at Codecov.
|
|
@eloquence @rmol Let me know if tests are required. |
conorsch
approved these changes
May 18, 2021
There was a problem hiding this comment.
@prateekj117 Thanks for tackling. Tested the changes locally, and the behavior works as intended: a manually removed directory will be recreated, no error is shown, and subsequent submissions succeed. Just what we wanted.
In the future, please do try to include tests to validate the behavior you're introducing!
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
If an admin accidentally or intentionally wipes out the store directory of a particular source (i.e., the
store/{filesystem_id}), the source gets aFileNotFoundErrorwhen trying to submitting the documents again.Fixes #5787
Changes proposed in this pull request:
A simple check which creates the
store/{filesystem_id}dir for a source if it not already exists.Testing
How should the reviewer test this PR?
Mentioned in the description of issue #5787
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development container