Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Rust to the builder image #5966

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

kushaldas
Copy link
Contributor

Status

Ready for review

Description of Changes

Version 1.52.1 of Rust.
After this is merged, we will have to push a new image. And then update #5964

Testing

  • CI should be green
  • @zenmonkeykstop can push a new builder image based on this

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you added or removed a file deployed with the application:

  • I have updated AppArmor rules to include the change

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

@kushaldas kushaldas requested a review from a team as a code owner May 28, 2021 10:04
@kushaldas
Copy link
Contributor Author

The change from @zenmonkeykstop is great. I can not still merge this. Need help in approving and also pushing a new container image.

@zenmonkeykstop
Copy link
Contributor

Confirmed locally that the change builds an image with the 1.52.1 Rust toolchain in place. Gonna merge and build image.

@zenmonkeykstop zenmonkeykstop merged commit b6e3a01 into develop Jun 1, 2021
@zenmonkeykstop zenmonkeykstop deleted the install_rust_for_builds branch June 1, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants