Ensure firewalld is installed and configured #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now runner preparation does not configure firewalld service and open ports for NFS related services. As the result Vagrant can't mount NFS directory so no task will be run. This patch eliminates this kind of thing.
|
I never faced such errors. Could you explain it to me (or give some example)? |
|
Well, if you will use, for example, fedora cloud image with firewalld enabled by default and you will not open port for NFS related stuff, you will get something like this hashicorp/vagrant#5802 (comment) |
|
Ah now I got it. Thanks @slaykovsky ! The patch LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now runner preparation does not configure firewalld service and
open ports for NFS related services. As the result Vagrant can't
mount NFS directory so no task will be run.
This patch eliminates this kind of thing.