-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(channels): Add support for Bluesky #429
Conversation
0017035
to
53b7ce7
Compare
6b8a625
to
5bab2df
Compare
The enhanced logic verifies the validity of the content of new case posts, ensuring they adhere to character limits across all channels.
5bab2df
to
5cf25e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. A few comments, thank you!
One question. On Blue Sky, it seems that clients are responsible for including link previews when posting (they call these "cards"), instead of the server doing that work. is that correct? If so, do we do that? Do our posts come with previews or no?
1b75202
to
5c60521
Compare
f30cdf4
to
b2810d8
Compare
f3709ae
to
0ca1464
Compare
aed1ce5
to
336a2c8
Compare
@mlissner this PR is ready for another review. All the typos are fixed and I updated the templates to embed links within the text.
You're right, the client has to extract the metadata from the link to build previews
I added a helper method to automatically display link previews in posts when the post doesn't show thumbnails. Here are some screenshots: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tweaks, but otherwise looks good. Merge when ready!
9949652
to
81f9679
Compare
81f9679
to
21696ae
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR fixes #398.
Here's a summary of the changes introduced by this PR:
Registers Bluesky as a new channel and adds a new client class to handle requests to the Bluesky API. This custom client uses the Bluesky API to handle post creation and media uploads. Although the Bluesky Python API clients listed on the website are still under development, Our class focuses on the essential functionalities required for the bot's operations.
Integrate the new Bluesky API class to the
Channel
class propertiesRefines validation logic in the add-a-case form.
While testing the Bluesky API integration, I noticed that the platform handles links differently from Mastodon and X. Unlike Mastodon/X, Bluesky uses the full length of links. This discrepancy could lead to posts exceeding the character limit of the template, as the template class doesn't truncate content in such instances. The enhancement ensures that the combined length of the post's name, summary, and link adheres to the maximum allowable length. Additionally, an informative error message is now displayed to users when the content exceeds the limit. This message instructs users to modify the content of the form, possibly by using a different combination of name, summary, and link, and resubmit it for successful posting. Here's a screenshot of the error message