generated from freelawproject/new-project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redis): Add Redis and django-rq #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlissner
reviewed
Feb 2, 2023
}, | ||
} | ||
|
||
SESSION_ENGINE = "django.contrib.sessions.backends.cache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah. I didn't know this was possible. Awesome.
mlissner
requested changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small comments, but this looks great otherwise.
mlissner
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #35 by adding a number of new settings, adding Redis support and the django-rq package.
This PR introduces the following changes:
Redis and django-rq are added as dependencies.
This PR creates a file to store Redis settings and one to store setting related to RQ.
This PR adds Redis and the RQ worker to the docker compose file
The dockerfile is updated to create an image for the RQ worker.
The sentry,py file is updated to add the RQ integration
This PR creates an endpoint to trigger a failing rq task and also adds the endpoints to access the RQ dashboard
The .env.local file is updated to include variables related to Redis.