Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): Add Redis and django-rq #53

Merged
merged 21 commits into from
Feb 2, 2023
Merged

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Feb 2, 2023

This PR fixes #35 by adding a number of new settings, adding Redis support and the django-rq package.

This PR introduces the following changes:

  • Redis and django-rq are added as dependencies.

  • This PR creates a file to store Redis settings and one to store setting related to RQ.

  • This PR adds Redis and the RQ worker to the docker compose file

  • The dockerfile is updated to create an image for the RQ worker.

  • The sentry,py file is updated to add the RQ integration

  • This PR creates an endpoint to trigger a failing rq task and also adds the endpoints to access the RQ dashboard

  • The .env.local file is updated to include variables related to Redis.

@ERosendo ERosendo marked this pull request as ready for review February 2, 2023 20:46
},
}

SESSION_ENGINE = "django.contrib.sessions.backends.cache"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah. I didn't know this was possible. Awesome.

Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but this looks great otherwise.

docker/django/Makefile Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@mlissner mlissner merged commit f180f40 into main Feb 2, 2023
@mlissner mlissner deleted the 35-add-redis-and-task-queue branch February 2, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add redis and a task queue
2 participants