fix(utils): Prevent incorrect CSV data appending due to shared variable #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `generate_docket_entries_csv_data` to avoid using a common variable within the inner loop. - This change addresses a bug that was causing duplicate or incorrect data in the generated CSV file.
ERosendo
force-pushed
the
4362-feat-upgrade-export-docket-feature
branch
from
fe516d9
to
3cacc71
Compare
ERosendo
force-pushed
the
4362-feat-upgrade-export-docket-feature
branch
from
3cacc71
to
71a66fc
Compare
ERosendo
force-pushed
the
4362-feat-upgrade-export-docket-feature
branch
from
71a66fc
to
c3c2486
Compare
mlissner
reviewed
Aug 28, 2024
This commit moves the spinner icon to the right side of the button text and uses a custom class to control its visibility, replacing the previous opacity-based approach.
|
@mike Thanks for your comments. Here are updated gifs for medium and large screen sizes: Medium screen size:Regular Download
Ratelimit Error
Large screen size:Regular Download
Ratelimit Error
|
mlissner
approved these changes
Aug 29, 2024
|
Nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug that was leading to inaccurate data in the exported CSV file. To address this issue, we've refactored the
generate_docket_entries_csv_datafunction to avoid using a common variable within the inner loop.This PR implements a rate limiter to control the frequency of CSV exports per hour. Additionally, the
de_listtemplate has been modified to display a loading spinner while the export request is in progress. If the rate limit is reached, an error message will be shown to inform the user about the issue.Here are some gifs showing the spinner and the error message:
Small screen size:
Regular Download
Ratelimit Error
Medium screen size:
Regular Download
Ratelimit Error
Large screen size:
Regular Download
Ratelimit Error
Fixes #4362