4487 Fixed entry_date_filed display on RECAP Search results #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is set for auto-merge, but tests are failing. Feel free to merge once they're happy. :) |
…ns during search tests
|
I fixed the test related to factories. However, I also saw this test also randomly failing: |
albertisfu
deleted the
4487-fix-entry-date-filed-display-search-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4487. The issue was that child documents from ES are strings, so they need to be converted to date objects before formatting. The previous approach was weak because it only extracted the day and appended
thto it.Now, the code relies on Django's built-in
date_filter, which properly formats dates following English rules (1st, 2nd, 3rd, 4th, and so on). It also fixes the issue of adding a leading zero to days less than 10.