Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Set cache control header to the advanced view #4502

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(search): Set cache control header to the advanced view #4502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e028a
fix(search): Set cache control header to the advanced view
ERosendo Sep 27, 2024
656d0ae
feat(api): Fix typos in the migration guide
ERosendo Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions cl/api/templates/migration-guide.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,24 +160,20 @@ <h3 id="opinions-breaking-changes">Opinions (type=o)</h3>
</ul>
<h3 id="oa-breaking-changes">Oral Arguments (type=oa)</h3>
<ul>
<li>The <code>snippet</code> field, currently stores a variety of fields. After the change, it will contain the audio transcription only.
<li>The <code>snippet</code> field currently stores a variety of fields. After the change, it will contain the audio transcription only.
</li>
</ul>
<h3 id="people-breaking-changes">People</h3>
<ul>
<li>No breaking changes. v3 is already switched to ElasticSearch.</li>
</ul>
<h2 id="migrate-db-apis">How Do I Migrate Database APIs to&nbsp;v4?</h2>
<h3 id="total-count-results">Total count of results</h3>
<ul>
<li>The total count of the results is no longer available in the response.
Most users don't need this when crawling the API, and computing the count for each response slows down the API.
If this value is essential to your service, let us know so we can discuss adding a new API with this feature.
</li>
</ul>
<h3 id="total-count-results">Result Count is Removed</h3>
<p>The total count of the results is no longer available in the response. Most users don't need this when using the API, and computing the count for each response slows down the API.
If this value is important to your service, let us know so we can discuss adding a new API with this feature.</p>
<h3 id="invalid-cursor">Invalid cursor error code: 404</h3>
<p>A new type of error in the v4 API is <strong>Invalid Cursor</strong> with a 404 status code.</p>
<p>This can happen when GET parameters are changed without getting a fresh cursor parameter. To prevent this error, do not change the GET parameters while maintaining an existing cursor paramter.
<p>This can happen when GET parameters are changed without getting a fresh cursor parameter. To prevent this error, do not change the GET parameters while maintaining an existing cursor parameter.
</p>
<h2 id="migrate-search-apis">How Do I Migrate the Search API to&nbsp;v4?</h2>
<h3 id="enhancements-v4">Enhancements in v4</h3>
Expand Down
1 change: 1 addition & 0 deletions cl/search/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@ def show_results(request: HttpRequest) -> HttpResponse:
return TemplateResponse(request, "search.html", render_dict)


@never_cache
def advanced(request: HttpRequest) -> HttpResponse:
render_dict = {"private": False}

Expand Down
Loading