Skip to content

Commit

Permalink
fix(scripts): Corrected typo in build script
Browse files Browse the repository at this point in the history
This commit fixes a typo in the path of the favicon file within release build script. The incorrect path was preventing the favicon from being rendered in the browser. By correcting the typo, the favicon will now be displayed as expected.
  • Loading branch information
ERosendo committed Sep 18, 2024
1 parent 5bd3f10 commit 61c1a71
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Changes:
- None yet

Fixes:
- None yet
- Corrected typo in build script, ensuring correct favicon path for Firefox releases([379](https://github.com/freelawproject/recap/issues/379), [397](https://github.com/freelawproject/recap-chrome/pull/397))

For developers:
- Nothing yet
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ zipName=$browserType-release.zip
# 3. Rename base manifest file
cd src/ && mv manifest.json manifest.base.json
if [[ "$browserType" == "firefox" ]]; then
faviconUrl='assets/images/favicon.icon'
faviconUrl='assets/images/favicon.ico'
# Remove unnecessary properties for Firefox manifest
jq 'del(.background.service_worker)' manifest.base.json >manifest.json
else
Expand Down

0 comments on commit 61c1a71

Please sign in to comment.