Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): Add review links to the last tab of the Extension #303

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Jan 3, 2023

This PR adds review links to the last tab of the extension and resolves freelawproject/recap#286.

This PR includes the following changes:

  • This PR changes the name of the last tab in the extension Popup from "Donate" to "Help RECAP".

  • The donate button is aligned with the amount input.

  • A new section is added in the last tab. This new section asks users for reviews and includes a link to the web store. This PR adds some code to detect the browser name and shows a different link depending on which browser is being used.

Additional comments

  • The extension will use the link to the Chrome Web Store in Microsoft Edge.

Here's a picture of the tab in different browsers

Google Chrome - version 108.0.5359.125

Firefox - 108.0.1 (64-bit)

Microsoft Edge - version 108.0.1462.54

- This commit changes the name of the last tab from "Donate" to "Help RECAP".
- Change the styling of the donate button.
- This commit adds another section in the last tab to ask users for reviews.
@ERosendo ERosendo requested a review from mlissner January 3, 2023 22:05
@ERosendo ERosendo marked this pull request as ready for review January 3, 2023 22:10
@mlissner
Copy link
Member

mlissner commented Jan 3, 2023

Cool, merging. I'd put the browser detection into a function of some kind since we'll probably want it somewhere else eventually, but we can live with it as is, thanks. Can you please make sure to do a changelog update for this though?

@mlissner mlissner merged commit 2bcb03a into main Jan 3, 2023
@mlissner mlissner deleted the 286_update_donate_tab branch January 3, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a "please review RECAP" link to the settings
2 participants