-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(district): Add button to autofill docket query form #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form - This commit adds two helper functions in the utils.js file. The first method is pacerDateFormat, which takes a date and returns it in 'MM/DD/YYYY' format. The other function is recapAddLatestFilingButton, this helper creates the HTML element that is inserted on the page.
- This commit uses the new helper method to add the filing button next to the date input field.
mlissner
requested changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few q's/comments, but approach looks sound, thank you!
Co-authored-by: Mike Lissner <mike@free.law>
Co-authored-by: Mike Lissner <mike@free.law>
…awproject/recap-chrome into 190-add-last-filing-button
mlissner
approved these changes
Jan 10, 2023
Awesome. If this passes your QA, let's deploy today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves freelawproject/recap#190.
This PR introduces the following changes:
A new field is added to the
getAvailabilityForDocket
request. This PR adds thedate_last_filing
field to the list of dynamically selected fields.This PR adds two helper functions in the utils.js file.
pacerDateFormat
: takes a date and returns it in 'MM/DD/YYYY' formatrecapAddLatestFilingButton
: creates the HTML button that is inserted on the page and also creates an onClick event listener for this object. This utility function uses thedate_last_filing
from the response ofgetAvailabilityForDocket
request to create a data attribute in the button.This PR adds CSS classes to change the styling of the new button.
The helper method called
removeBanners
is updated to also remove the new button.This PR adds the helper method
recapAddLatestFilingButton
to the Docket Query handler to create the filing button next to the date input field of the form.Here's a gif showing the feature: