fix(appellate): Avoid uploading case summary with the wrong case_id #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit adds a new helper function called getDocketNumber. This new helper uses different approaches to get the docket number from the appellate pages. - The method called findDocLinksFromAnchors is updated to add a new query parameter in the anchor's URL called recapCaseNum
|
Looks good, I think. We'll see if it causes any trouble! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes freelawproject/recap#330.
This PR introduces the following changes:
This commit adds a new helper function called
getDocketNumber. This new helper uses different approaches to get the docket number from the appellate pages.A new URL query parameter is added to the anchor's href attribute. This new query parameter is called
recapCaseNum. This new parameter will be used as the last resource to get the docket number from an appellate page.This PR updates the methods
handleCaseSelectionPage,handleCaseQueryPage,attachRecapLinksToEligibleDocs,handleDocketDisplayPageandhandleSingleDocumentPageViewfrom the AppellateDelegate class to save the docket number to the tab storage.Update the helper method called
getCaseIdto check the docket number of the appellate page before using thepacer_case_idsaved in the local storage.