Improve Document Selection Menu page matching

[ttys0dev]

The existing match conditions for attachment pages doesn't seem to be reliable(ie for example on cacd), lets just add a match condition for the "Document Selection Menu" text at the top as well which seems to fix these issues.

[mlissner]

This LGTM, but sending to @ERosendo to make sure he's happy too.

[ERosendo]

This looks good.

I tested your code using a few attachment pages from cacd ( like entry #1 from 2:23-cv-05413), and It works great.

Our current approach is failing because those attachment pages don't have buttons to download/view the documents as they usually do, which is odd since the checkboxes remain there, and the page still contains all the JS code that computes the total number of pages and the total size of the selected documents. The console is showing a lot of errors related to those missing HTML elements.

@ttys0dev Thanks!

@mlissner we can merge this 👍

[mlissner]

Should we fix all those errors while we're looking at this part of the code?

[ERosendo]

We could try, but it's the JS code from PACER that's creating those errors, not the extension.

The extension works properly using this approach to identify attachment pages with this issue. It attaches the Recap icon to documents that we have in the RECAP archive and it can upload new ones. I uploaded attachment 3 of entry #1 from 2:23-cv-05413.

[mlissner]

Got it, thanks. Merging, but we need release notes too. :)