fix(appellate): Remove the logic to normalize the pacer_dls_id #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems OK, but tests are failing. :) |
|
@mlissner it is ready now. The new action to check the release notes is working properly :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the QA steps, I realized the extension failed to upload free documents. After debugging the code, I noticed we're using the pacer_dls_id attribute in the onClickEventHandlerForDocLinks to create the request that allows us to check whether the doc link returns an HTML page (the view document page) or a pdf file (when it's free). sending the normalized version of the dls_id always returns an HTML page even when the doc is an opinion (which is a free doc).
This PR removes the logic to normalize the
dls_id.